Skip to content

Align with changes to LCA_oM #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Align with changes to LCA_oM #139

merged 1 commit into from
Jun 13, 2025

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1641

Issues addressed by this PR

Align with changes in the LCA_oM

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Jun 10, 2025
@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jun 10, 2025
pawelbaran
pawelbaran approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Propagating the approval from @kayleighhoude BHoM/LifeCycleAssessment_Toolkit#357

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Versioning_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on Versioning_Toolkit

@bhombot-ci BHoMBot-CI
Copy link

bhombot-ci bot commented Jun 13, 2025

@IsakNaslundBh just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@IsakNaslundBh IsakNaslundBh merged commit 688213a into develop Jun 13, 2025
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the LifeCycleAssessment_Toolkit-#306-AddCalculatedMaterialLifeCycleEnvironmentalImpactFactors branch June 13, 2025 11:07
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelbaran pawelbaran pawelbaran approved these changes

@michaelhoehn michaelhoehn Awaiting requested review from michaelhoehn

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsakNaslundBh @pawelbaran