From 4ba225b115e80b416b494b57f446e8bdadae9793 Mon Sep 17 00:00:00 2001 From: pshao25 <97225342+pshao25@users.noreply.github.com> Date: Tue, 19 Sep 2023 16:49:34 +0800 Subject: [PATCH 1/3] Update openai spec to use access and usage --- .../OpenAI.Inference/client.tsp | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/specification/cognitiveservices/OpenAI.Inference/client.tsp b/specification/cognitiveservices/OpenAI.Inference/client.tsp index 6a68b5b38d5e..f0ab34efb3ab 100644 --- a/specification/cognitiveservices/OpenAI.Inference/client.tsp +++ b/specification/cognitiveservices/OpenAI.Inference/client.tsp @@ -5,15 +5,25 @@ using Azure.ClientGenerator.Core; // Azure-specific long-running operations should be treated as implementation details that are wrapped into // appropriately merged public surface. -@@internal(Azure.OpenAI.beginAzureBatchImageGeneration); -@@internal(Azure.OpenAI.getAzureBatchImageGenerationOperationStatus); +@@access(Azure.OpenAI.beginAzureBatchImageGeneration, Access.internal); +@@access(Azure.OpenAI.getAzureBatchImageGenerationOperationStatus, Access.internal); // Azure-specific Chat Completions with extensions should be handled by clients as a conditional selection within the // shared Chat Completions route, with the selection gated by the presence or non-presence of additional child // configuration options on the request payload options model. -@@internal(Azure.OpenAI.getChatCompletionsWithAzureExtensions); +@@access(Azure.OpenAI.getChatCompletionsWithAzureExtensions, Access.internal); // Some models from routes with suppressed visibility are still desired for custom public surface. -@@include(Azure.OpenAI.ImageGenerationOptions); -@@include(Azure.OpenAI.ImageLocation); -@@include(Azure.OpenAI.ImageGenerations); +@@access(Azure.OpenAI.ImageGenerationOptions, Access.public); +@@access(Azure.OpenAI.ImageLocation, Access.public); +@@access(Azure.OpenAI.ImageGenerations, Access.public); +@@access(Azure.OpenAI.ImageSize, Access.public); + +@@access(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions, Access.public); +@@usage(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions, Usage.input); + +@@access(Azure.OpenAI.AzureCognitiveSearchQueryType, Access.public); +@@usage(Azure.OpenAI.AzureCognitiveSearchQueryType, Usage.input); + +@@access(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, Access.public); +@@usage(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, Usage.input); From 8f13627230772d90c8db09636e88b9a26dc73044 Mon Sep 17 00:00:00 2001 From: pshao25 <97225342+pshao25@users.noreply.github.com> Date: Mon, 30 Oct 2023 15:59:40 +0800 Subject: [PATCH 2/3] update --- .../OpenAI.Inference/client.tsp | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/specification/cognitiveservices/OpenAI.Inference/client.tsp b/specification/cognitiveservices/OpenAI.Inference/client.tsp index f0ab34efb3ab..1d3068c510fe 100644 --- a/specification/cognitiveservices/OpenAI.Inference/client.tsp +++ b/specification/cognitiveservices/OpenAI.Inference/client.tsp @@ -6,7 +6,9 @@ using Azure.ClientGenerator.Core; // Azure-specific long-running operations should be treated as implementation details that are wrapped into // appropriately merged public surface. @@access(Azure.OpenAI.beginAzureBatchImageGeneration, Access.internal); -@@access(Azure.OpenAI.getAzureBatchImageGenerationOperationStatus, Access.internal); +@@access(Azure.OpenAI.getAzureBatchImageGenerationOperationStatus, + Access.internal +); // Azure-specific Chat Completions with extensions should be handled by clients as a conditional selection within the // shared Chat Completions route, with the selection gated by the presence or non-presence of additional child @@ -19,11 +21,17 @@ using Azure.ClientGenerator.Core; @@access(Azure.OpenAI.ImageGenerations, Access.public); @@access(Azure.OpenAI.ImageSize, Access.public); -@@access(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions, Access.public); +@@access(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions, + Access.public +); @@usage(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions, Usage.input); @@access(Azure.OpenAI.AzureCognitiveSearchQueryType, Access.public); @@usage(Azure.OpenAI.AzureCognitiveSearchQueryType, Usage.input); -@@access(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, Access.public); -@@usage(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, Usage.input); +@@access(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, + Access.public +); +@@usage(Azure.OpenAI.AzureCognitiveSearchChatExtensionConfiguration, + Usage.input +); From b04407707ee37cbbcbd033fa0911f2bec6aa5a08 Mon Sep 17 00:00:00 2001 From: Pan Shao <97225342+pshao25@users.noreply.github.com> Date: Thu, 9 Nov 2023 15:10:46 +0800 Subject: [PATCH 3/3] Update specification/cognitiveservices/OpenAI.Inference/client.tsp Co-authored-by: Shawn Fang <45607042+mssfang@users.noreply.github.com> --- specification/cognitiveservices/OpenAI.Inference/client.tsp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/specification/cognitiveservices/OpenAI.Inference/client.tsp b/specification/cognitiveservices/OpenAI.Inference/client.tsp index 1d3068c510fe..ee5754738b05 100644 --- a/specification/cognitiveservices/OpenAI.Inference/client.tsp +++ b/specification/cognitiveservices/OpenAI.Inference/client.tsp @@ -18,7 +18,9 @@ using Azure.ClientGenerator.Core; // Some models from routes with suppressed visibility are still desired for custom public surface. @@access(Azure.OpenAI.ImageGenerationOptions, Access.public); @@access(Azure.OpenAI.ImageLocation, Access.public); -@@access(Azure.OpenAI.ImageGenerations, Access.public); +@@access(Azure.OpenAI.ImageGenerations, Access.public, "csharp"); +@@access(Azure.OpenAI.ImageGenerations, Access.public, "python"); +@@access(Azure.OpenAI.ImageGenerations, Access.public, "javascript"); @@access(Azure.OpenAI.ImageSize, Access.public); @@access(Azure.OpenAI.AzureCognitiveSearchIndexFieldMappingOptions,