Skip to content

Fixed missing XA_WM_NAME remove on empty window Title #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

Al-Dyachkov
Copy link
Contributor

What does the pull request do?

Adds removing XA_WM_NAME property when setting empty title

What is the current behavior?

XA_WM_NAME is not removed when title is empty, leading to broken window title on Linux

Title = "Тест";
Title = null;

leads to

image

What is the updated/expected behavior with this PR?

Empty window title is displayed

@dnfadmin
Copy link

dnfadmin commented Nov 15, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems good.. pinging @kekekeks

@jmacato jmacato merged commit 4728a75 into AvaloniaUI:master Nov 16, 2021
danwalmsley pushed a commit that referenced this pull request Nov 23, 2021
Fixed missing XA_WM_NAME remove on empty window Title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants