Skip to content

Fix #5151 same as Microsoft #5203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix #5151 same as Microsoft #5203

merged 2 commits into from
Jan 11, 2021

Conversation

mike-ward
Copy link
Contributor

What does the pull request do?

ItemsRepeater does not update sometimes when inserting into front of list.

What is the current behavior?

ItemsRepeater leaves blank space where new items should appear. Scrolling even 1 pixel restores view.

What is the updated/expected behavior with this PR?

Tried to implement a unit test but frankly, I couldn't figure out how.

How was the solution implemented (if it's not obvious)?

Copies a similar fix made by Microsoft microsoft/microsoft-ui-xaml#3699

Checklist

Breaking changes

Fixed issues

Fixes #5151

@dnfadmin
Copy link

dnfadmin commented Dec 21, 2020

CLA assistant check
All CLA requirements met.

@maxkatz6 maxkatz6 requested a review from grokys December 21, 2020 22:38
Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mike-ward !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ItemsRepeater: Inserting at front sometimes results in unrendered items
4 participants