Fix NativeMenuBar tooltip #15505
Merged
Fix NativeMenuBar tooltip #15505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
backport-candidate-11.1.x
maxkatz6
added a commit
that referenced
this pull request
Apr 25, 2024
* Fix native menu bar tooltip * Make ToolTip tests more reliable * Increase MacOS_Native_Menu_Has_ToolTip_If_Defined sleep delay * Disable MacOS_Native_Menu_Has_ToolTip_If_Defined, as it fails way too often
|
You can test this PR using the following package version. |
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This ToolTip binding was initially implemented e0c6e11#diff-be87dacae55b7a692260605dbb473e14db722954af3adaaee4ccc323d4902603R15, but lost in following NativeMenuBar refactoring. Which resulted in a flaky test, that was only passing because there was another node with expected text.
This PR: